reverendsteveii

@reverendsteveii@lemm.ee

Solitary, poor, nasty, brutish and short

This profile is from a federated server and may be incomplete. Browse more on the original instance.

reverendsteveii, (edited )

`//Get CustomerInfo from CustomerRepository by Customer ID or else throw an CustomerNotFoundException

public CustomerInfo getById(String customerId) {


<span style="color:#323232;">return customerRepository.getById(customerId).orElseThrow(new CustomerNotFoundException());
</span>

}`

This is the kind of pointless comment I see in my codebase all the time. Best I can tell, a couple of my coworkers like to plan out their code using comments, then backfill in the actual executable code. That’s fine, but they leave the comments in when they add no value.

` public static LocalDate parseEndDateFromString(String dateString) {


<span style="color:#323232;">    try {
</span><span style="color:#323232;">
</span><span style="color:#323232;">        String[] split = dateString.split("-");
</span><span style="color:#323232;">
</span><span style="color:#323232;">        //In order to get the last day of the desired month, we go to the first day of the next month, account for rollover, then subtract one day
</span><span style="color:#323232;">
</span><span style="color:#323232;">        int month = Integer.parseInt(split[0]) == 12 ? 1 : Integer.parseInt(split[0]) + 1;
</span><span style="color:#323232;">
</span><span style="color:#323232;">        return LocalDate.of(Integer.parseInt(split[1]), month, 1).minusDays(1);
</span><span style="color:#323232;">
</span><span style="color:#323232;">    } catch (Exception e) {
</span><span style="color:#323232;">
</span><span style="color:#323232;">        throw new RuntimeException("Invalid date format - must be MM-YYYY");
</span><span style="color:#323232;">
</span><span style="color:#323232;">    }
</span><span style="color:#323232;">
</span><span style="color:#323232;">}`
</span>

Stuff like this, otoh, is where comments are useful. The required format is obvious from the error message, the param and return from the method signature, the only part that requires a comment is the fiddly logic of accounting for the edge case where month == 12 and the rationale behind how we determine the last day of the month. As a rule, comments are for why something is being done, if it’s not obvious, and for magic numbers. Code should tell you what code does.

edit: can anyone spot the bug that I introduced with that parseEndDateFromString() method?

reverendsteveii,

manager in code review

theresYourProblem.jpg

reverendsteveii,

anyone who wants to leave can go. Hell, I’m responsible for two of the lost users because when i first came over here I misunderstood how this works and made a new account on each instance. what’s up @reverendsteveii and @reverendsteveii?

reverendsteveii,

burnout paradise. I’ll just put on a podcast and drive around. Sometimes I’m seeking out races, or new best times on roads. Sometimes I’m just driving around more or less obeying traffic laws like a reasonable citizen.

reverendsteveii,

I work on a Web app and we recently decided that we’re just not gonna support double quotes in free text fields because oh holy balls what a thing it is to try to deal with those in a way that doesn’t open you up to multiple encoding vulnerabilities.

reverendsteveii,

The only reasonable response to this behavior is disproportionate violence

reverendsteveii, (edited )

The issue is the filter that we’re using to avoid multiple encoding attacks de-escapes everything via multiple rounds, then tries to pass it to the next layer of filtering with the de-escaped request body as a json string. Your absolutely right that this is a silly way of doing it, but sometimes we have to live with decisions that were made before we were onboarded to a project. In this particular case, I pushed to improve the filters but all our PO heard was “spend development time weakening security” and at the end of the day they decide what to do and we do it.

reverendsteveii, (edited )

You should tell that to OWASP then, they wrote it. org.owasp.esapi 2.5.2.0, class is Encoder, method is canonicalize(String, bool, bool)

reverendsteveii,

6 years into my career as a ReSTMonkey, this is absolutely still me

reverendsteveii,

lemm.ee/comment/6088169

What’s wild is there seems to be a contingent on lemmy that goes into posts like this just to say “who cares that they harvest all your data?”

reverendsteveii,

*scrimps

reverendsteveii, (edited )

Anonamouse just announced that they’re likely to ban some client/version pairs precisely because of announce floods. Thing is, does the problem clear up instantly when the client is killed, or does it take time? The latter would indicate a server side van expiring, the former some issue on the client side.

reverendsteveii,

OP link us to the comment where you merely mentioned Tiananmen square and got banned for it

reverendsteveii,

Crunt.

Wait a minute, lemme try again.

Curbt.

Well f*ck…

reverendsteveii,

This is a way. Mando aside, the audiobook bay is better than spending money but it’s not anywhere near as good as private trackers like anonamouse

reverendsteveii,

Sounds like you could save them buckets of money by redesigning their whole backend. They’d probably pay you idiot money to do so, in terms of seven figures per year at least for the cost and performance enhancements you seem to think are easily achievable.

So why aren’t you doing that?

reverendsteveii,

state’s rights

wanted the federal government to override the rights of free states

made slavery mandatory rather than leaving it up to the states

tried to flat-out steal entire states using violence

Like every conservative, when they talk about freedom they’re only talking about their freedom to do what they want, and their freedom to make you do what they want using violence.

reverendsteveii,

what if you’re the problem?

reverendsteveii,

I just leave my last 30 or so torrents open. They have strict rules, but they’re simple to follow. If you just leave your torrents open you’ll follow the rules and accumulate enough bonus points for permanent free VIP rather quickly.

reverendsteveii,

It’s neat how they include both Confederate flags

reverendsteveii,

And I’m so sorry

reverendsteveii,

antiblick

We in South Africa rn?

Disney is gouging customers with a near doubling of subscription costs. (sh.itjust.works)

Disney is raking its customers over the coals with a 75% price hike for their annual subscription (originally $80.) People wonder why piracy is on the rise.Multiple commenters are saying I’m off base about the 75% price increase. My payment less than a year ago was $79.99. Here’s the proof.

reverendsteveii,

Unsub’d. Fuck that noise, I really only use them for Simpsons reruns between movies I give a shit about. So now I’ll steal the Simpsons and the movies. They overplayed their hand here.

I know this is not how dbzer0 works, but can you help me get cs 1.6 working on my linux system ? (lemmy.dbzer0.com)

I downloaded the game from soft32 (this file used to work on the old days). I installed both WINE and Lutris, but the game runs like sh**t. I get .NET and Vulkan errors from Lutris&WINE. Can you give me a newbie friendly guide for the right way? I’m tired of scrapping the web and it doesn’t help that I have limited data....

reverendsteveii,

I get errors…

Post them as top level comments on this post

reverendsteveii, (edited )

Once again, because it’s come up so many times in this thread, not at all vegan, definitely omnivorous, just not someone who assumes their membership in the majority defines them as a victim unlike the coward Wage_slave@lemmy.ml

  • All
  • Subscribed
  • Moderated
  • Favorites
  • •
  • localhost
  • All magazines
    •
    Loading…
    Loading the web debug toolbar…
    Attempt #